Solid to react dev #37
Conversation
- Bump vite to 4.5.2 to solve security issue reported by dependabot in
https://github.com/hyperledger/cacti/pull/2999
- Update other vite and build plugins to latest versions.
- Update solidjs and solidjs router to fix runtime issues.
Signed-off-by: Michal Bajer <[email protected]>
| @@ -0,0 +1,18 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
Usun config eslinta, uzywaj tego z roota
| @@ -0,0 +1,24 @@ | |||
| # Logs | |||
There was a problem hiding this comment.
To samo z gitignore, jesli cos z tego nie jest ignorowane to dodaj w glowny .gitignore
| @@ -0,0 +1,30 @@ | |||
| # React + TypeScript + Vite | |||
There was a problem hiding this comment.
README wiadomo zaktualizowac z tym co bylo
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Vite + React + TS</title> |
There was a problem hiding this comment.
i wywal package.lock, wszystko yarnem powinno sie instalowac tak jak to jest w obecnej paczce
| }, | ||
| "type": "module", | ||
| "scripts": { | ||
| "dev": "vite", |
There was a problem hiding this comment.
skrypty musza byc takie jak w poprzendiej paczce, w szcegolnosci build:*:frontend
| function CustomTable(props) { | ||
|
|
||
|
|
||
| const [viewport, setViewport] = useState(""); |
There was a problem hiding this comment.
tutaj cos duzo tych spacji po funkcji, odpal linta przed PR zeby porpawil wszystkie bledy takie
| @@ -0,0 +1,68 @@ | |||
| /* :root { | |||
| ]); | ||
|
|
||
| ReactDOM.createRoot(document.getElementById("root")!).render( | ||
| <React.StrictMode> |
There was a problem hiding this comment.
strict mode mozesz zakomentowac przed PR
| import { useNavigate } from "react-router-dom"; | ||
| import { useEffect, useState } from "react"; | ||
| import CardWrapper from "../../../components/CardWrapper/CardWrapper"; | ||
| // import { Transaction } from "../../../schema/supabase-types"; |
| export default FabricBlock; | ||
|
|
||
| { | ||
| /* |
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.